[farsight2/master] rtpsession: Fix potential leak if already disposed

Olivier Crête olivier.crete at collabora.co.uk
Tue Sep 1 15:51:05 PDT 2009


---
 gst/fsrtpconference/fs-rtp-session.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/gst/fsrtpconference/fs-rtp-session.c b/gst/fsrtpconference/fs-rtp-session.c
index dd22edc..6bd2ed5 100644
--- a/gst/fsrtpconference/fs-rtp-session.c
+++ b/gst/fsrtpconference/fs-rtp-session.c
@@ -1707,12 +1707,14 @@ fs_rtp_session_set_codec_preferences (FsSession *session,
 {
   FsRtpSession *self = FS_RTP_SESSION (session);
   GList *old_codec_prefs = NULL;
-  GList *new_codec_prefs = fs_codec_list_copy (codec_preferences);
+  GList *new_codec_prefs = NULL;
   gboolean ret;
 
   if (fs_rtp_session_has_disposed_enter (self, error))
     return FALSE;
 
+  new_codec_prefs = fs_codec_list_copy (codec_preferences);
+
   new_codec_prefs =
     validate_codecs_configuration (
         self->priv->media_type, self->priv->blueprints,
-- 
1.5.6.5




More information about the farsight-commits mailing list