failed build because of shared-modules/intl-tools

[Muayyad AlSadi]

> builddir/files/share/appdata/com.github.ojubaorg.Othman.appdata.xml:
FAILED:
> • tag-missing           : <name> is not present

our appdata does not look like other's

https://github.com/flathub/com.github.ojubaorg.Othman/blob/master/com.github.ojubaorg.Othman.appdata.xml
https://gitlab.gnome.org/World/podcasts/blob/master/podcasts-gtk/resources/org.gnome.Podcasts.appdata.xml.in.in

is there some documentation on this?



On Mon, Sep 23, 2019 at 2:30 PM Muayyad AlSadi <alsadi at gmail.com> wrote:

> sorry, my bad.
> it's building now
>
> someone suggested I test my changes first using a pull request
>
>
> https://github.com/flathub/com.github.ojubaorg.Othman/commit/b5bfb6fd000f2f26df130929042857b0c1adfab1
>
> > The build seems to fail. Please test the builds first by sending a PR to
> the repo or locally.
>
> so how can I do that? should I put it on a branch and do a build on that
> branch? does buildbot support that?
>
>
>
> <https://github.com/flathub/com.github.ojubaorg.Othman/commit/b5bfb6fd000f2f26df130929042857b0c1adfab1>
>
> On Mon, Sep 23, 2019 at 1:13 PM Alexander Larsson <alexl at redhat.com>
> wrote:
>
>> Well, this is the checkout log:
>> https://flathub.org/builds/#/builders/8/builds/1025/steps/2/logs/stdio
>>
>> This says its using commit b5bfb6fd000f2f26df130929042857b0c1adfab1,
>> which does seem to be the latest, no?
>>
>> On Mon, Sep 23, 2019 at 11:43 AM Muayyad AlSadi <alsadi at gmail.com> wrote:
>> >
>> > are you sure it's doing "git fetch" and "git pull origin master"
>> > because I see
>> >
>> > /usr/bin/python3 setup.py install -O2 --root /
>> >
>> > which no longer exists in the Makefile
>> >
>> > the build command in the json says
>> >
>> >         "build-commands": [
>> >                 "make PREFIX=/app install"
>> >         ],
>> >
>> > which should translate to
>> >
>> > $(PYTHON) setup.py install --prefix=$(PREFIX)
>> >
>> >
>> > https://flathub.org/builds/#/builders/8/builds/1025
>> >
>> > On Mon, Sep 23, 2019 at 11:08 AM Alexander Larsson <alexl at redhat.com>
>> wrote:
>> >>
>> >> On Sun, Sep 22, 2019 at 2:08 PM Muayyad AlSadi <alsadi at gmail.com>
>> wrote:
>> >> >
>> >> > hi,
>> >> >
>> >> > I've followed this
>> >> >
>> >> >
>> https://github.com/flathub/flathub/wiki/App-Requirements#shared-modules
>> >> >
>> >> > git submodule add https://github.com/flathub/shared-modules.git
>> >> >
>> >> >     "modules": [
>> >> >     "shared-modules/intltool/intltool-0.51.json",
>> >> > ...
>> >> >
>> https://github.com/flathub/com.github.ojubaorg.Othman/blob/master/com.github.ojubaorg.Othman.json
>> >> >
>> >> > https://flathub.org/builds/#/builders/32/builds/8624
>> >> >
>> >> >  but I got
>> >> >
>> >> > (flatpak-builder:23380): flatpak-builder-ERROR **: 18:06:17.239:
>> Failed to load included manifest
>> (/srv/buildbot-master/master/workers/MasterWorker6/Builds/build/shared-modules/intltool/intltool-0.51.json):
>> Failed to open file
>> “/srv/buildbot-master/master/workers/MasterWorker6/Builds/build/shared-modules/intltool/intltool-0.51.json”:
>> No such file or directory
>> >>
>> >> This was a bug in the latest buildbot update (it didn't do a git
>> >> submodule checkout when it should). I pushed a fix for it todays, so
>> >> just retry any failed builds.
>> >>
>> >> --
>> >> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>> >>  Alexander Larsson                                Red Hat, Inc
>> >>        alexl at redhat.com         alexander.larsson at gmail.com
>> >>
>>
>>
>> --
>> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>>  Alexander Larsson                                Red Hat, Inc
>>        alexl at redhat.com         alexander.larsson at gmail.com
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/flatpak/attachments/20190923/29fae276/attachment.html>