<div dir="ltr">sorry, my bad.<div>it's building now</div><div><br></div><div>someone suggested I test my changes first using a pull request</div><div><br></div><div><a href="https://github.com/flathub/com.github.ojubaorg.Othman/commit/b5bfb6fd000f2f26df130929042857b0c1adfab1">https://github.com/flathub/com.github.ojubaorg.Othman/commit/b5bfb6fd000f2f26df130929042857b0c1adfab1</a><br></div><div><br></div><div>> The build seems to fail. Please test the builds first by sending a PR to the repo or locally.</div><div><br></div>so how can I do that? should I put it on a branch and do a build on that branch? does buildbot support that?<div><br><div><br></div><div><a href="https://github.com/flathub/com.github.ojubaorg.Othman/commit/b5bfb6fd000f2f26df130929042857b0c1adfab1"></a><br></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Sep 23, 2019 at 1:13 PM Alexander Larsson <<a href="mailto:alexl@redhat.com">alexl@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Well, this is the checkout log:<br>
<a href="https://flathub.org/builds/#/builders/8/builds/1025/steps/2/logs/stdio" rel="noreferrer" target="_blank">https://flathub.org/builds/#/builders/8/builds/1025/steps/2/logs/stdio</a><br>
<br>
This says its using commit b5bfb6fd000f2f26df130929042857b0c1adfab1,<br>
which does seem to be the latest, no?<br>
<br>
On Mon, Sep 23, 2019 at 11:43 AM Muayyad AlSadi <<a href="mailto:alsadi@gmail.com" target="_blank">alsadi@gmail.com</a>> wrote:<br>
><br>
> are you sure it's doing "git fetch" and "git pull origin master"<br>
> because I see<br>
><br>
> /usr/bin/python3 setup.py install -O2 --root /<br>
><br>
> which no longer exists in the Makefile<br>
><br>
> the build command in the json says<br>
><br>
>         "build-commands": [<br>
>                 "make PREFIX=/app install"<br>
>         ],<br>
><br>
> which should translate to<br>
><br>
> $(PYTHON) setup.py install --prefix=$(PREFIX)<br>
><br>
><br>
> <a href="https://flathub.org/builds/#/builders/8/builds/1025" rel="noreferrer" target="_blank">https://flathub.org/builds/#/builders/8/builds/1025</a><br>
><br>
> On Mon, Sep 23, 2019 at 11:08 AM Alexander Larsson <<a href="mailto:alexl@redhat.com" target="_blank">alexl@redhat.com</a>> wrote:<br>
>><br>
>> On Sun, Sep 22, 2019 at 2:08 PM Muayyad AlSadi <<a href="mailto:alsadi@gmail.com" target="_blank">alsadi@gmail.com</a>> wrote:<br>
>> ><br>
>> > hi,<br>
>> ><br>
>> > I've followed this<br>
>> ><br>
>> > <a href="https://github.com/flathub/flathub/wiki/App-Requirements#shared-modules" rel="noreferrer" target="_blank">https://github.com/flathub/flathub/wiki/App-Requirements#shared-modules</a><br>
>> ><br>
>> > git submodule add <a href="https://github.com/flathub/shared-modules.git" rel="noreferrer" target="_blank">https://github.com/flathub/shared-modules.git</a><br>
>> ><br>
>> >     "modules": [<br>
>> >     "shared-modules/intltool/intltool-0.51.json",<br>
>> > ...<br>
>> > <a href="https://github.com/flathub/com.github.ojubaorg.Othman/blob/master/com.github.ojubaorg.Othman.json" rel="noreferrer" target="_blank">https://github.com/flathub/com.github.ojubaorg.Othman/blob/master/com.github.ojubaorg.Othman.json</a><br>
>> ><br>
>> > <a href="https://flathub.org/builds/#/builders/32/builds/8624" rel="noreferrer" target="_blank">https://flathub.org/builds/#/builders/32/builds/8624</a><br>
>> ><br>
>> >  but I got<br>
>> ><br>
>> > (flatpak-builder:23380): flatpak-builder-ERROR **: 18:06:17.239: Failed to load included manifest (/srv/buildbot-master/master/workers/MasterWorker6/Builds/build/shared-modules/intltool/intltool-0.51.json): Failed to open file “/srv/buildbot-master/master/workers/MasterWorker6/Builds/build/shared-modules/intltool/intltool-0.51.json”: No such file or directory<br>
>><br>
>> This was a bug in the latest buildbot update (it didn't do a git<br>
>> submodule checkout when it should). I pushed a fix for it todays, so<br>
>> just retry any failed builds.<br>
>><br>
>> --<br>
>> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=<br>
>>  Alexander Larsson                                Red Hat, Inc<br>
>>        <a href="mailto:alexl@redhat.com" target="_blank">alexl@redhat.com</a>         <a href="mailto:alexander.larsson@gmail.com" target="_blank">alexander.larsson@gmail.com</a><br>
>><br>
<br>
<br>
-- <br>
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=<br>
 Alexander Larsson                                Red Hat, Inc<br>
       <a href="mailto:alexl@redhat.com" target="_blank">alexl@redhat.com</a>         <a href="mailto:alexander.larsson@gmail.com" target="_blank">alexander.larsson@gmail.com</a><br>
<br>
</blockquote></div>