[Fontconfig-bugs] [Bug 25535] Cache file does not get updated when files are added or removed to directory on FAT

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25535

--- Comment #21 from Akira TAGOH <akira at tagoh.org> 2012-05-01 01:00:38 PDT ---
Comment on attachment 60764
  --> https://bugs.freedesktop.org/attachment.cgi?id=60764
Fix-cache-aging-for-fonts-on-FAT-filesystem-under-Linux

Review of attachment 60764:
 --> (https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=25535&attachment=60764)
-----------------------------------------------------------------

I was presuming that this bug is targeted Windows platform but your patch looks
like just targeting FAT filesystem regardless of the platforms. so current code
of FcStat() works on Windows but not on other platforms that support FAT
filesystem?

::: src/fcstat.c
@@ +33,1 @@
>  

I don't think requiring the linux kernel header files are a good idea. we could
use the hardcode magic number instead, so far.

@@ +132,5 @@
> +
> +    if (FcDebug () & FC_DBG_CACHE)
> +	printf ("FcFsMtimeBroken %s\n", file);
> +
> +    ret = statfs ((const char *)file, &fs_stat);

FcFsMtimeBroken() can be revised according to the recent changes in master.
that supports multiple platforms for statv?fs() but not only for Linux. we may
want to have FcStatFS() to wrap up.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.