[Fontconfig-bugs] [Bug 80873] Improve size unparse?

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=80873

Behdad Esfahbod <freedesktop at behdad.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |freedesktop at behdad.org

--- Comment #3 from Behdad Esfahbod <freedesktop at behdad.org> ---
I don't like NOT showing something that is set.  Why is it set anyway?

Given that a missing SIZE will match with score 0, and a SIZE of (0,inf) also
always match with score 0, I really prefer that we DON'T set size if it's not
available.

I did a couple commits to that effect.  Please see:

  https://github.com/behdad/fontconfig/commits/size-rework

Needs testing.  On top of this, I want to see us clean up some more:

  - Remove the bits about range's is_inclusive,

  - Remove special-cases of ranges with start==end,

  - Move the part that sets FC_SIZE for bitmap-only fonts close to where
FC_PIXEL_SIZE is set, or remove it.  I don't think we had that part before and
you introduced it during adding ranges.

Why did you decide to set FC_SIZE as a range all the time to begin with?  It's
not required AFAIU.

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/fontconfig-bugs/attachments/20140704/373a73f8/attachment.html>