[Fontconfig-bugs] [Bug 80873] Improve size unparse?

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue May 19 11:05:18 PDT 2015


https://bugs.freedesktop.org/show_bug.cgi?id=80873

--- Comment #14 from Behdad Esfahbod <freedesktop at behdad.org> ---
(In reply to Akira TAGOH from comment #13)
> (In reply to comment #12)
> > I think this might be ready.  Akira, can you please review?
> > 
> > Thanks.
> 
> Well, "it matches any value perfectly" approach ignores the score when it
> exactly matches the value perfectly, doesn't it?

The become the same, yes.

> j is increased per matchers. speaking of FC_SIZE, j will be 9 at this
> moment. given that one tries to query with :size=12 say, and a cache doesn't
> contain FC_SIZE, the score will be 0 right. but if it has, the score will be
> 9.

9 is really small.  See:

  v = v * 1000 + j;

so if there's any difference, that would be at least 1000.  I don't think
that's a problem.


> in this case that works because an outlined font can takes care of it.
> how about the sort of flags? I tend to agree with not having the unnecessary
> values in the cache though, do we need to pay more attentions in
> FcDefaultSubstitute() to prevent such situation or improve the score
> estimation to make better even without it?

Do you have a clear example of that?

Lets try to land this soon.  Thanks.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/fontconfig-bugs/attachments/20150519/57776af6/attachment.html>


More information about the Fontconfig-bugs mailing list