[Fontconfig-bugs] [Bug 97546] fc-cache failure with /System/Library/Fonts

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=97546

Jeremy Huddleston Sequoia <jeremyhu at freedesktop.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEEDINFO                    |ASSIGNED

--- Comment #12 from Jeremy Huddleston Sequoia <jeremyhu at freedesktop.org> ---
Reviewed-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>
Tested-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

Review comments:
  The inner-most predicate is written with a side-effect and is otherwise
rather complex.  I'd suggest breaking the c-- out.
  Your whitespace usage for casting is not self-consistent.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/fontconfig-bugs/attachments/20161024/43923c2b/attachment.html>