<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - Make fontconfig cache relocatable" href="https://bugs.freedesktop.org/show_bug.cgi?id=101889#c52">Comment # 52</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - Make fontconfig cache relocatable" href="https://bugs.freedesktop.org/show_bug.cgi?id=101889">bug 101889</a> from <a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> Behdad Esfahbod</a> <pre>I reviewed. While generally looks good, and I'd be fine with this going in, my major concern is maintainability of this... 1. The copy paste hashmap implementation get annoying. We should abstract that away, 2. I think this has threadsafety issues. No? Since the lifecycle of what's put in the hashmaps is forever(ish), it's possible to make it threadsafe using pointer cmpexch(). Also, isn't the 4099 hash size a bit too large? 3. The maintainability... The whole cache code has become incomprehensible to me. I don't understand the code anymore. Some more abstractions can definitely make it much more understandable. 4. Would be great to at least have standalone tests for these. Is it possible to mount in-process without root privileges?</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>