<html>
<head>
<base href="https://bugs.freedesktop.org/">
</head>
<body>
<p>
<div>
<b><a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Relocated caches not quite working"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106618#c25">Comment # 25</a>
on <a class="bz_bug_link
bz_status_ASSIGNED "
title="ASSIGNED - Relocated caches not quite working"
href="https://bugs.freedesktop.org/show_bug.cgi?id=106618">bug 106618</a>
from <span class="vcard"><a class="email" href="mailto:freedesktop@behdad.org" title="Behdad Esfahbod <freedesktop@behdad.org>"> <span class="fn">Behdad Esfahbod</span></a>
</span></b>
<pre>Comment on <span class=""><a href="attachment.cgi?id=139730" name="attach_139730" title="Rewrite paths in caches earlier">attachment 139730</a> <a href="attachment.cgi?id=139730&action=edit" title="Rewrite paths in caches earlier">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=106618&attachment=139730'>[review]</a>
Rewrite paths in caches earlier
Review of <span class=""><a href="attachment.cgi?id=139730" name="attach_139730" title="Rewrite paths in caches earlier">attachment 139730</a> <a href="attachment.cgi?id=139730&action=edit" title="Rewrite paths in caches earlier">[details]</a></span> <a href='page.cgi?id=splinter.html&bug=106618&attachment=139730'>[review]</a>:
-----------------------------------------------------------------
::: src/fcpat.c
@@ +378,5 @@
<span class="quote">> +{
> + /* We use a value to find the cache, instead of the FcPattern object
> + * because the pattern itself may be a cache allocation if we rewrote the path,
> + * so the p may not be in the cached region. */
> + return FcPatternEltValues(&FcPatternElts (p)[0]);</span >
What if pattern is empty. Doesn't this cause invalid memory access?
Also, there's an assumption that cached patterns have at least two items and
FC_FILE is NOT the first one. Document this?</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are on the CC list for the bug.</li>
</ul>
</body>
</html>