<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - Relocated caches not quite working" href="https://bugs.freedesktop.org/show_bug.cgi?id=106618#c26">Comment # 26</a> on <a class="bz_bug_link bz_status_ASSIGNED " title="ASSIGNED - Relocated caches not quite working" href="https://bugs.freedesktop.org/show_bug.cgi?id=106618">bug 106618</a> from <a class="email" href="mailto:alexl@redhat.com" title="Alexander Larsson <alexl@redhat.com>"> Alexander Larsson</a> <pre>Comment on <a href="attachment.cgi?id=139730" name="attach_139730" title="Rewrite paths in caches earlier">attachment 139730</a> <a href="attachment.cgi?id=139730&action=edit" title="Rewrite paths in caches earlier">[details]</a> <a href='page.cgi?id=splinter.html&bug=106618&attachment=139730'>[review]</a> Rewrite paths in caches earlier Review of <a href="attachment.cgi?id=139730" name="attach_139730" title="Rewrite paths in caches earlier">attachment 139730</a> <a href="attachment.cgi?id=139730&action=edit" title="Rewrite paths in caches earlier">[details]</a> <a href='page.cgi?id=splinter.html&bug=106618&attachment=139730'>[review]</a>: ----------------------------------------------------------------- ::: src/fcpat.c @@ +378,5 @@ > +{ > + /* We use a value to find the cache, instead of the FcPattern object > + * because the pattern itself may be a cache allocation if we rewrote the path, > + * so the p may not be in the cached region. */ > + return FcPatternEltValues(&FcPatternElts (p)[0]); This is only called for cached patterns, which I doubt are empty, and since the elements are in order, and FILE is index 21 after things like family, style and size I think this is unlikely to happen. Maybe that should be documented and verified in the code though.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are on the CC list for the bug.</li> </ul> </body> </html>