[Fontconfig] Patch: fix memleak (spotted by Coverity)

Frederic Crozat fcrozat at mandriva.com
Mon Apr 10 09:31:01 PDT 2006

Le lundi 10 avril 2006 à 12:07 -0400, Patrick Lam a écrit :
> Frederic Crozat wrote:
> > The following patch fixes memory and file descriptor leaks (Coverity
> > reports #777 and #1826) in error cases for FcDirScanConfig.
> > 
> > Please review this patch carefully, as I used goto for bail conditions
> > and tried to call free functions only one time in the FcDirScanConfig
> > code (to ease code review in the future).
> I've committed a modified version of this patch.  I think it's correct.

It looks ok to me.

To celebrate, here is another memleak fix (Coverity report #1824) for
FcDirCacheUnlink ;)

Don't worry, there are only 28 defects left to check, I'll probably
continue tomorrow...

Frederic Crozat <fcrozat at mandriva.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fontconfig-2.3.94-hashmemleak2.patch
Type: text/x-patch
Size: 1129 bytes
Desc: not available
Url : http://lists.freedesktop.org/archives/fontconfig/attachments/20060410/842963e6/fontconfig-2.3.94-hashmemleak2.bin

More information about the Fontconfig mailing list