[Fontconfig] strange code in FcCharSetPutLeaf (spotted by Coverity)

Frederic Crozat fcrozat at mandriva.com
Tue Apr 11 06:56:33 PDT 2006


Coverity found two memory leaks in fccharset.c : FcCharSetPutLeaf (#1192
and #1193) in the "if (fcs->bank != FC_BANK_DYNAMIC)" TRUE branch :
leaves and numbers. But after reading this part of the code, I'm not
sure if it is doing anything at all : memory is allocated for leaves and
numbers but those variables are not used at all after "if () {} else {}"
stuff, so they are leaked and not used at all..

Could somebody with much more knowledge of this code check it ?

-- 
Frederic Crozat <fcrozat at mandriva.com>
Mandriva



More information about the Fontconfig mailing list