[Fontconfig] Re: [PATCH] fix crashes on malformed fonts.cache

Patrick Lam plam at MIT.EDU
Fri Feb 3 15:05:55 PST 2006


Dirk Mueller wrote:
> Hi, 
> 
> This one fixes a memory overrun when a fonts.cache file is slightly malformed. 
> other places probably need similiar fixes. 

Other places probably ought to be fixed similarly, although this is
unlikely to happen by chance.

> -    if (nfont > 0)
> +    if (nfont > 0 && s->nfont < s->nfont + nfont)

I'm about to commit the correct version of this patch, which doesn't
include the inadvertently wholly redundant check...

pat


More information about the Fontconfig mailing list