[Fontconfig] Re: Bug: listing fonts with missing BDF properties

Mike FABIAN mfabian at suse.de
Mon Feb 13 14:20:08 PST 2006

Patrick Lam <plam at MIT.EDU> さんは書きました:

> Mike FABIAN wrote:
>> +		goto bail1;
> I think that should be bail1, because cs isn't freed yet.  I've
> committed with a goto to bail2.

I see.

Then what about the two "bail1" a few lines up?:

    if (!(face->face_flags & FT_FACE_FLAG_SCALABLE))
    for (i = 0; i < face->num_fixed_sizes; i++)
        if (!FcPatternAddDouble (pat, FC_PIXEL_SIZE,
                                           FcGetPixelSize (face, i)))
                                                          goto bail1;
(!FcPatternAddBool (pat, FC_ANTIALIAS, FcFalse))
                       goto bail1;

Shouldn't those be "bail2" as well?

Mike FABIAN   <mfabian at suse.de>   http://www.suse.de/~mfabian

More information about the Fontconfig mailing list