[Fontconfig] [PATCH] Wrong encoding for TT_MS_ID_UCS_4

[Behdad Esfahbod]

On 07/22/2009 05:06 PM, Yuriy Kaminskiy wrote:
> On 24.06.2009 19:42, Yuriy Kaminskiy wrote:
>> In ttf namelists TT_PLATFORM_MICROSOFT/TT_MS_ID_UCS_4 uses UTF-16BE
>> encoding, not UCS4 (as can be implied from name);
> ping.

Are you sure?  This is what I see in the code:

static const FcFtEncoding   fcFtEncoding[] = {
  {  TT_PLATFORM_APPLE_UNICODE,↦ TT_ENCODING_DONT_CARE,↦ "UCS-2BE" },
  {  TT_PLATFORM_MACINTOSH,↦     TT_MAC_ID_ROMAN,↦       "MACINTOSH" },
  {  TT_PLATFORM_MACINTOSH,↦     TT_MAC_ID_JAPANESE,↦    "SJIS" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_UNICODE_CS,↦   "UTF-16BE" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_SJIS,↦ ↦       "SJIS-WIN" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_GB2312,↦       "GB2312" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_BIG_5,↦↦       "BIG-5" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_WANSUNG,↦      "Wansung" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_JOHAB,↦↦       "Johab" },
  {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_UCS_4,↦↦       "UCS4" },
  {  TT_PLATFORM_ISO,↦   ↦       TT_ISO_ID_7BIT_ASCII,↦  "ASCII" },
  {  TT_PLATFORM_ISO,↦   ↦       TT_ISO_ID_10646,↦       "UCS-2BE" },
  {  TT_PLATFORM_ISO,↦   ↦       TT_ISO_ID_8859_1,↦      "ISO-8859-1" },
};


Been there since 2004.

behdad