[Fontconfig] [PATCH] Wrong encoding for TT_MS_ID_UCS_4

[Behdad Esfahbod]

On 07/22/2009 07:23 PM, Yuriy Kaminskiy wrote:
> On 23.07.2009 01:10, Behdad Esfahbod wrote:
>> On 07/22/2009 05:06 PM, Yuriy Kaminskiy wrote:
>>> On 24.06.2009 19:42, Yuriy Kaminskiy wrote:
>>>> In ttf namelists TT_PLATFORM_MICROSOFT/TT_MS_ID_UCS_4 uses UTF-16BE
>>>> encoding, not UCS4 (as can be implied from name);
>>> ping.
>> Are you sure?  This is what I see in the code:
> [shurg] I did not checked any standards on this, but that's what I have in
> practice (i.e. on real font; before my change it's garbled, after - all ok); and
> what I see in freetype2 code. See original post for details.
> <http://permalink.gmane.org/gmane.comp.fonts.fontconfig/3193>
>>    {  TT_PLATFORM_MICROSOFT,↦     TT_MS_ID_UCS_4,↦↦       "UCS4" },
>> Been there since 2004.
> Yep. As I said in original post, `patch applies to fontconfig from 2.3.95 to
> 2.6.99' (did not checked earlier/later versions).
> That's just quite rarely used, and counter-intuitive, so no-one noticed.

Ah, ok, I thought you mean the other way around.  Fixed.

behdad