[Fontconfig] Questionable usage of FcPatternAddInteger()

[Raimund Steger]

Hi,

On Mon, April 30, 2012 10:11, Fabian Greffrath wrote:
> [...]
> So as you both point out, the culprit is not necessarily
> FcPatternAddInteger() but the trimming of FcFontSort()'s results,
> which may cause dropping of some reasonable candidates.

I think so.

>> (I'm also not too positive about passing 0 as pointer to 'result'. Is
>> that allowed for FcFontSort()?)
>
> Is it fine to pass NULL instead of 0 or does it have to be an actual
> pointer?

It will be assigned to, so it would have to be a non-null pointer, like:

  FcResult result;
  [...]
  candidates = FcFontSort (0, pattern, FcTrue, 0, &result);



Raimund


-- 
Worringer Str 31 Duesseldorf 40211 Germany +49-179-2981632 icq 16845346