[Fontconfig] [PATCHv2 0/3] Updated version of previous patches

[Akira TAGOH]

Hi,

Thanks for the patch. that indeed looks better than the previous one.

> diff --git a/src/fcxml.c b/src/fcxml.c
> index a146068..d7d917f 100644
> --- a/src/fcxml.c
> +++ b/src/fcxml.c
> @@ -2056,7 +2056,10 @@ FcParseInclude (FcConfigParse *parse)
>        ignore_missing = FcTrue;
>     attr = FcConfigGetAttribute (parse, "deprecated");
>     if (attr && FcConfigLexBool (parse, (FcChar8 *) attr) == FcTrue)
> +    {
>         deprecated = FcTrue;
> +        ignore_missing = FcTrue;
> +    }

I'm not sure how it's useful. I don't even see any case if users
explicitly want to use the deprecated flag in their own configuration.
this was added for XDG base directory specification transition and it
will be dropped in the future once the enough time passed away. I'd
rather encourage people to consider adding ignore_missing="yes" in
their configuration if it's the case.


On Fri, Jun 22, 2012 at 4:01 AM, Marius Tolzmann <tolzmann at molgen.mpg.de> wrote:
> hi..
>
> please ignore the first patch series.. it won't work as intended
> but at least it won't break anything either.. 8)
>
> sorry for the noise..
>
> this is an updated patch that also fixes the logic of deprecated
> config file include for the future:
>
> it assumes that if you set a config file to be deprecated, that
> it is ok to also set ignore_missing to true to enable the user to
> get rid off the warning by removing the directory in question..
>
> It also does not use FcStat() anymore since this was not able to
> handle ~ home directories..
>
> please review.. because this was the first time i looked
> into the sources of fontconfig 8)
>
> thx..
>
> bye marius tolzmann...
>
>
> Marius Tolzmann (3):
>  Fix newline in warning about deprecated config includes
>  Fix warning about deprecated, non-existent config includes
>  Assume ignore_missing on deprecated config includes
>
>  src/fcxml.c |   19 ++++++++++++++++---
>  1 files changed, 16 insertions(+), 3 deletions(-)
>
> --
> 1.7.5.2
>
> _______________________________________________
> Fontconfig mailing list
> Fontconfig at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/fontconfig



-- 
Akira TAGOH