[Fontconfig] REGRESSION: 2.11, cache is always rebuilt for root font directories (Was Re: fontconfig: Branch 'master')

[Jeremy Huddleston Sequoia]

Looks good.

Tested-by: Jeremy Huddleston Sequoia <jeremyhu at apple.com>

On Dec 19, 2013, at 23:53, Akira TAGOH <akira at tagoh.org> wrote:

> no one tested this one?
> 
> On Thu, Dec 5, 2013 at 7:22 PM, Akira TAGOH <akira at tagoh.org> wrote:
>> just made a patch for this issue.
>> 
>> http://cgit.freedesktop.org/~tagoh/fontconfig/commit/?h=bz69845
>> 
>> any volunteers for testing are welcome.
>> 
>> On Tue, Nov 5, 2013 at 11:40 AM, Akira TAGOH <akira at tagoh.org> wrote:
>>> On Tue, Nov 5, 2013 at 8:19 AM, Jeremy Huddleston Sequoia
>>> <jeremyhu at freedesktop.org> wrote:
>>>> This commit introduces a bad performance regression.  Every time fc-cache is run, it runs through the directories twice.  The first time, it sees valid caches and does nothing.  The second time, it always rebuilds.
>>> 
>>> Not rebuilding everything. as it commented in the source code as well
>>> as the git log, it was supposed to enforce to rebuild the directory
>>> cache only for certain font path non-recursively. that said it was
>>> just a situation what I was expecting and could be improved
>>> furthermore. let me think about this.
>>> 
>>> Thanks for reporting,
>>> --
>>> Akira TAGOH
>> 
>> 
>> 
>> --
>> Akira TAGOH
> 
> 
> 
> -- 
> Akira TAGOH
> _______________________________________________
> Fontconfig mailing list
> Fontconfig at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/fontconfig
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/pkcs7-signature
Size: 4154 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/fontconfig/attachments/20140101/eef5df83/attachment.bin>