[Fontconfig] [PATCH] don't artificially embolden fixed-width fonts

[Adam Williamson]

On Sat, 2015-02-14 at 14:02 +0100, Raimund Steger wrote:
> On 02/12/15 01:32, Raimund Steger wrote:
> > > > > [...]
> > 
> > I'll have a look at them over the weekend. I think it should be 
> > possible to isolate the interesting part.
> 
> I've taken a look at freetype-entire-infinality-patchset-20130514-
> 01.patch now and I think the relevant part is only the following 
> (the patch contains other changes to emboldening, but these address 
> unrelated things like pixel snapping):
> 
> diff --git a/src/base/ftsynth.c b/src/base/ftsynth.c
> index 241d37f..3d5a593 100644
> --- a/src/base/ftsynth.c
> +++ b/src/base/ftsynth.c
> @@ -141,6 +173,9 @@
> 
>       slot->metrics.width       += xstr;
>       slot->metrics.height      += ystr;
> +#ifdef FT_CONFIG_OPTION_INFINALITY_PATCHSET
> +    if ( !use_various_tweaks )
> +#endif
>       slot->metrics.horiAdvance += xstr;
>       slot->metrics.vertAdvance += ystr;
> 
> If I replace the "if ( !use_various_tweaks )" with "if ( 
> !FT_IS_FIXED_WIDTH( face ) )", I seem to come up with a patch that 
> keeps
> the advance width for monospace fonts and leaves the rest unchanged. 
> (Suggestion attached; note it's only created with quilt from a 2.5.5 
> tarball.) I've put up screenshots of Lucida Console at
> http://steg0.eu/saurus/2015/02.emboldenmono/.
> 
> Could this already be it...??

Ah, that's interesting!

So my next move in cases like this tends to be to think "OK, so why 
isn't it that way now?" But it certainly looks good. I quite enjoy 
playing git Sherlock Holmes, so I'll have a poke through and see if I 
can find any skeletons in the closet that suggest that change might 
cause any problems, but it sure looks promising! Thanks a lot for 
figuring that out.
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net