[Fontconfig] [PATCH] Do not remove UUID file when a scanned directory is empty

Akira TAGOH akira at tagoh.org
Mon Nov 5 07:52:04 UTC 2018

a few more comments for your changes.

Please keep doc for FcDirCacheCreateUUID but describe deprecated. this
causes make check fails. also good to use FC_PATH_MAX instead of
PATH_MAX. PATH_MAX seems not defined on GNU/Hurd. see abdb6d65. there
are one more PATH_MAX in the existing code which I missed correcting
when merging. that would be appreciated if you can update it too.
For last one, well, I know this is ugly hack but I did to get tests
working though, please sync up FcConfig structure to test/test-conf.c,
particularly if you are going to change the member of them or adding a
member earlier like this. this is the reason why the CI pipeline on
GitLab failed.
This is needed to build the virtual FcFontSet for testing though,
dunno if I should add an API to access instead of accessing the
structure directly, because I don't expect to use it for non-testing

Anyway, otherwise that looks good. please submit a MR for that.

On Fri, Nov 2, 2018 at 3:15 AM Keith Packard <keithp at keithp.com> wrote:
> We might consider creating a new element that resets the directory list
> to empty?
>         <reset-dirs/>
>         <dir>~/.fonts</dir>
> would remove all system-specified font directories and add ~/.fonts.

That could be used anytime anywhere. doesn't it make a trouble?

> --
> -keith


More information about the Fontconfig mailing list