[fprint] libfprint-0.5.0 bug report

[Vasily Khoruzhick]

On Tue, Apr 30, 2013 at 11:02 AM, David Binderman <dcb314 at hotmail.com>wrote:

> Hello there,
>

Hi David,


> I just ran the static analyser "cppcheck" over the source code of
> libfprint-0.5.0
>

Thanks!


> and it said
>
> 1.
>
> [drivers/vfs101.c:192]: (warning) Logical conjunction always evaluates to
> false: result < 0 && result >= 3.
>
> Suggest replace && with ||
>

OK, but I've no vfs101 device to test.


>
> 2.
>
> [img.c:154]: (error) Resource leak: fd
>

OK


> [drivers/aesx660.c:296]: (error) Memory leak: stripdata
>

OK


> [nbis/bozorth3/bz_alloc.c:116]: (error) Memory leak: p
> [nbis/bozorth3/bz_io.c:421]: (error) Resource leak: fp
> [nbis/mindtct/init.c:593]: (error) Memory leak: powers
> [nbis/mindtct/init.c:682]: (error) Memory leak: powmax_dirs
> [nbis/mindtct/maps.c:662]: (error) Memory leak: cimage
> [nbis/mindtct/maps.c:722]: (error) Memory leak: pmap
> [nbis/mindtct/maps.c:729]: (error) Memory leak: pmap
>
>
I don't want to touch nbis code until it fails


> I checked the first couple and they did look like real problems, although
> minor.
>
> Regards
>
> David Binderman
> _______________________________________________
> fprint mailing list
> fprint at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/fprint
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/fprint/attachments/20130430/4b33a505/attachment.html>