[fprint] [PATCH vfs101] Logical conjunction always evaluates to false.

Bastien Nocera hadess at hadess.net
Mon Feb 9 03:48:44 PST 2015


Hey Carlos,

On Fri, 2015-02-06 at 17:22 +0100, Carlos Olmedo Escobar wrote:
> Signed-off-by: Carlos Olmedo Escobar <carlos.olmedo.e at gmail.com>

We don't use signed-off-bys. We also prefer patches to be attached to
bugzilla, this avoids them getting lost.

I've however committed this one.

Cheers

> ---
>  libfprint/drivers/vfs101.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libfprint/drivers/vfs101.c b/libfprint/drivers/vfs101.c
> index db0b06e..84624eb 100644
> --- a/libfprint/drivers/vfs101.c
> +++ b/libfprint/drivers/vfs101.c
> @@ -186,7 +186,7 @@ static int result_codes[2][RESULT_COUNT] =
>  static int result_code(struct fp_img_dev *dev, int result)
>  {
>  	/* Check result value */
> -	if (result < 0 && result >= RESULT_COUNT)
> +	if (result < 0 || result >= RESULT_COUNT)
>  		return result;
>  
>  	/* Return result code */




More information about the fprint mailing list