[Freedreno] [PATCH 13/16] drm/msm: gpu: Add support for the GPMU

[Stanimir Varbanov]

Hi Rob,

On 11/07/2016 03:02 PM, Rob Clark wrote:
> On Mon, Nov 7, 2016 at 7:58 AM, Stanimir Varbanov
> <stanimir.varbanov at linaro.org> wrote:
>>> +     /* Turn off protected mode for this operation */
>>> +     OUT_PKT7(ring, CP_SET_PROTECTED_MODE, 1);
>>
>> This looks wrong, shouldn't it be?
> 
> no, it is actually correct, the 3rd arg is # of dwords of payload in
> the msg.  So the payload of the CP_SET_PROTECTED_MODE packet is the
> following OUT_RING(ring, 0)

Ahh, understood now. Sorry for the noise :)

-- 
regards,
Stan