[Freedreno] [DPU PATCH v2 2/2] drm/panel: add backlight control support for truly panel

Bjorn Andersson bjorn.andersson at linaro.org
Tue Apr 17 21:29:01 UTC 2018


On Tue 17 Apr 11:21 PDT 2018, abhinavk at codeaurora.org wrote:
> On 2018-04-16 23:13, Bjorn Andersson wrote:
[..]
> > If the panel isn't actually a piece of backlight hardware then it should
> > not register a backlight device. Why do you need your own sysfs?
> > 
> > Regards,
> > Bjorn
> [Abhinav] This particular panel isnt a piece of backlight hardware.
> But, we want to have our own sysfs to give flexibility to our userspace
> to write and read stuff for its proprietary uses.

Please be more specific in your replies, no one will accept code that
"does stuff" and expecting a reviewer to spend time guessing or pulling
the information out of you is a sure way to get your patches ignored.

Exactly what kind of stuff are you talking about here and exactly which
problem are you solving.

> Thats how our downstream has been working so far and hence to maintain
> the compatibility would like to have it.

Make your proprietary code work with the upstream kernel and you
shouldn't ever have to modify it.

Regards,
Bjorn


More information about the Freedreno mailing list