[Freedreno] [[RFC]DPU PATCH 4/4] dt-bindings: Add Innolux TV123WAM panel bindings

[Rob Herring]

On Wed, Apr 18, 2018 at 05:50:02PM +0530, Sandeep Panda wrote:
> The Innolux TV123WAM is a 12.3" eDP display panel
> with 2160x1440 resolution.

Why don't you just submit this for upstream?

> 
> Signed-off-by: Sandeep Panda <spanda at codeaurora.org>
> ---
>  .../bindings/display/panel/innolux,edp-2k-panel.txt | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
> 
> diff --git a/Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt b/Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
> new file mode 100644
> index 0000000..19f271c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/innolux,edp-2k-panel.txt
> @@ -0,0 +1,21 @@
> +Innolux TV123WAM 12.3 inch eDP display panel
> +
> +Required properties:
> +- power-supply: regulator to provide the supply voltage
> +- enable-gpios: GPIO pin to enable or disable the panel

Need to state the active state.

> +
> +Optional properties:
> +- backlight: phandle of the backlight device attached to the panel
> +
> +Example:
> +
> +	edp_panel: edp_panel {

panel {

> +		compatible = "innolux, edp_2k_panel";

spurious space                        ^

> +		reg = <0>;

Not documented. Should be dropped.

> +
> +		enable-gpios = <&msmgpio 32 GPIO_ACTIVE_HIGH>;
> +
> +		power-supply = <&pm8916_l8>;
> +

Remove the extra blank lines.

> +		backlight = <&backlight>;
> +	};
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html