[Freedreno] [PATCH] drm: Convert to using %pOFn instead of device_node.name

Rob Herring robh at kernel.org
Tue Aug 28 15:04:22 UTC 2018


On Tue, Aug 28, 2018 at 7:54 AM Maarten Lankhorst
<maarten.lankhorst at linux.intel.com> wrote:
>
> Op 28-08-18 om 03:52 schreef Rob Herring:
> > In preparation to remove the node name pointer from struct device_node,
> > convert printf users to use the %pOFn format specifier.
> >
> > Cc: Gustavo Padovan <gustavo at padovan.org>
> > Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> > Cc: Sean Paul <sean at poorly.run>
> > Cc: David Airlie <airlied at linux.ie>
> > Cc: Rob Clark <robdclark at gmail.com>
> > Cc: dri-devel at lists.freedesktop.org
> > Cc: linux-arm-msm at vger.kernel.org
> > Cc: freedreno at lists.freedesktop.org
> > Signed-off-by: Rob Herring <robh at kernel.org>
> > ---
> >  drivers/gpu/drm/drm_modes.c     | 4 ++--
> >  drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +-
> >  2 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/drm_modes.c b/drivers/gpu/drm/drm_modes.c
> > index 02db9ac82d7a..24a750436559 100644
> > --- a/drivers/gpu/drm/drm_modes.c
> > +++ b/drivers/gpu/drm/drm_modes.c
> > @@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np,
> >       if (bus_flags)
> >               drm_bus_flags_from_videomode(&vm, bus_flags);
> >
> > -     pr_debug("%pOF: got %dx%d display mode from %s\n",
> > -             np, vm.hactive, vm.vactive, np->name);
> > +     pr_debug("%pOF: got %dx%d display mode\n",
> > +             np, vm.hactive, vm.vactive);
> Aren't you removing it here instead of converting?

Well, yes. The full path and name are already printed so the node name
alone was pretty redundant.

Rob


More information about the Freedreno mailing list