[Freedreno] [bug report] drm/msm: add a5xx specific debugfs

Dan Carpenter dan.carpenter at oracle.com
Wed Feb 7 11:52:32 UTC 2018


Hello Rob Clark,

This is a semi-automatic email about new static checker warnings.

The patch 024ad8df763f: "drm/msm: add a5xx specific debugfs" from Dec 
13, 2017, leads to the following Smatch complaint:

    ./drivers/gpu/drm/msm/adreno/a5xx_debugfs.c:166 a5xx_debugfs_init()
    warn: variable dereferenced before check 'minor' (see line 162)

./drivers/gpu/drm/msm/adreno/a5xx_debugfs.c
   161	{
   162		struct drm_device *dev = minor->dev;
                                         ^^^^^^^^^^
Dereference

   163		struct dentry *ent;
   164		int ret;
   165	
   166		if (!minor)
                    ^^^^^^
Check

   167			return 0;
   168	

regards,
dan carpenter


More information about the Freedreno mailing list