[Freedreno] [RFC PULL] Add Display Support for Qualcomm SDM845

Rob Herring robh at kernel.org
Fri Feb 16 01:25:37 UTC 2018


On Tue, Feb 13, 2018 at 1:18 PM, Sean Paul <seanpaul at chromium.org> wrote:
> Hi dri-devel,
> Qualcomm has been working for the past few weeks on forward porting their
> downstream drm driver from 4.14 to mainline. Please consider this PR as a
> request for review, rather than an attempt at mainlining the code as it
> currently stands. The goal is get this driver in shape over the next coming
> months.
>
> In the meantime, I'll be hosting a tree here [1] to stage the fixes. Patches
> will be posted and reviewed on linux-arm-msm at vger.kernel.org. Once things look
> good, I'll send another pull 4realz.
>
> To get the ball rolling, I've done some review on the new connector code, my
> comments are below.
>
> Thanks in advance for your constructive feedback :)


>  .../devicetree/bindings/display/msm/dpu-rsc.txt    |   96 +
>  .../devicetree/bindings/display/msm/dpu.txt        |  736 +++
>  .../devicetree/bindings/display/msm/dsi.txt        |   16 +

>  .../devicetree/bindings/drm/msm/dpu-dp.txt         |  217 +
>  .../devicetree/bindings/drm/msm/dpu-dsi.txt        |  102 +
>  .../devicetree/bindings/drm/msm/dpu-wb.txt         |   23 +
>  .../devicetree/bindings/drm/msm/mdss-dsi-panel.txt |  772 +++

Not a correct path with /drm/.

772 lines for a panel or DSI!? I look at it when it is shorter...

>  .../devicetree/bindings/fb/mdss-dsi-panel.txt      |  742 +++

Hopefully just duplicated?

>  Documentation/devicetree/bindings/fb/mdss-pll.txt  |  103 +

Not a correct path either.

>  .../devicetree/bindings/msm_hdcp/msm_hdcp.txt      |   14 +

ditto.

Rob


More information about the Freedreno mailing list