[Freedreno] [PATCH RESEND 10/10] drm/msm: Restore msm_atomic_check hook

[Sean Paul]

On Thu, Feb 22, 2018 at 03:08:55PM -0500, Rob Clark wrote:
> On Wed, Feb 21, 2018 at 10:18 AM, Sean Paul <seanpaul at chromium.org> wrote:
> > Somehow this got lost, put it back. We might want to re-evaluate whether
> > this is actually necessary, but for now let's actually use the thing.
> >
> > Signed-off-by: Sean Paul <seanpaul at chromium.org>
> 
> we might need this atm, although I'd prefer trying to move back to
> original atomic check/commit/etc to start with.  Personally I'd rather
> be moving in the direction of using the generic helpers (only reason
> it doesn't now is they didn't exist when I did initial atomic
> conversion, and no one has gotten around to this cleanup yet).

I suspect we can get rid of it. iirc, the dpu check didn't do anything
interesting yet. I didn't want to rip it all out yet, but I'll add it to the
trello and revisit once it bubbles up to the top of the stack (when I go through
the msm core changes).

Sean

> 
> If the kthread-per-crtc scheme ends up being useful, it should
> probably be done in the atomic-helpers rather than in-driver, to
> ensure more consistent behavior (and bug-fixes) across drivers..
> 
> BR,
> -R
> 
> 
> > ---
> >  drivers/gpu/drm/msm/msm_drv.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> > index 30c56b873fbe..eda4a2340f93 100644
> > --- a/drivers/gpu/drm/msm/msm_drv.c
> > +++ b/drivers/gpu/drm/msm/msm_drv.c
> > @@ -119,7 +119,7 @@ int msm_atomic_check(struct drm_device *dev,
> >  static const struct drm_mode_config_funcs mode_config_funcs = {
> >         .fb_create = msm_framebuffer_create,
> >         .output_poll_changed = msm_fb_output_poll_changed,
> > -       .atomic_check = drm_atomic_helper_check,
> > +       .atomic_check = msm_atomic_check,
> >         .atomic_commit = msm_atomic_commit,
> >         .atomic_state_alloc = msm_atomic_state_alloc,
> >         .atomic_state_clear = msm_atomic_state_clear,
> > --
> > 2.16.1.291.g4437f3f132-goog
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Sean Paul, Software Engineer, Google / Chromium OS