[Freedreno] [[DPU]PATCH] drm/msm/dsi: move the API setting PLL src to modeset_init()

Doug Anderson dianders at chromium.org
Tue Jun 26 15:55:22 UTC 2018


Hi,

On Mon, Jun 25, 2018 at 9:45 PM, Sandeep Panda <spanda at codeaurora.org> wrote:
> From: Abhinav Kumar <abhinavk at codeaurora.org>
>
> Setting the DSI PLL src in probe doesn't provide the clock
> driver sufficient time to reclaim unused clock resources
> from coreboot resulting in warnings from clock driver.
>
> Move the DSI PLL src setting to modeset_init() so that the
> clock driver can claim unused display clock resources before
> the display driver requests for them again.

IMHO this is a bad design.  Sean and Stephen can feel free to override
me, but I think the clock driver should be improved to handle this
case and not require the clock to get disabled before Linux enables
it.

-Doug


More information about the Freedreno mailing list