[Freedreno] [PATCH 13/13] drm/msm/gpu: Add the buffer objects from the submit to the crash dump

[kbuild test robot]

Hi Jordan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robclark/msm-next]
[also build test WARNING on v4.18-rc2 next-20180629]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jordan-Crouse/drm-msm-Capture-and-dump-the-GPU-crash-state/20180630-015229
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   drivers/gpu/drm/msm/adreno/adreno_gpu.c: In function 'adreno_show':
>> drivers/gpu/drm/msm/adreno/adreno_gpu.c:537:31: warning: format '%ld' expects argument of type 'long int', but argument 3 has type 'size_t {aka unsigned int}' [-Wformat=]
       drm_printf(p, "    size: %ld\n", state->bos[i].size);
                                ~~^     ~~~~~~~~~~~~~~~~~~
                                %d

vim +537 drivers/gpu/drm/msm/adreno/adreno_gpu.c

   500	
   501	void adreno_show(struct msm_gpu *gpu, struct msm_gpu_state *state,
   502			struct drm_printer *p)
   503	{
   504		struct adreno_gpu *adreno_gpu = to_adreno_gpu(gpu);
   505		int i;
   506	
   507		if (IS_ERR_OR_NULL(state))
   508			return;
   509	
   510		drm_printf(p, "revision: %d (%d.%d.%d.%d)\n",
   511				adreno_gpu->info->revn, adreno_gpu->rev.core,
   512				adreno_gpu->rev.major, adreno_gpu->rev.minor,
   513				adreno_gpu->rev.patchid);
   514	
   515		drm_printf(p, "rbbm-status: 0x%08x\n", state->rbbm_status);
   516	
   517		drm_puts(p, "ringbuffer:\n");
   518	
   519		for (i = 0; i < gpu->nr_rings; i++) {
   520			drm_printf(p, "  - id: %d\n", i);
   521			drm_printf(p, "    last-fence: %d\n", state->ring[i].seqno);
   522			drm_printf(p, "    retired-fence: %d\n", state->ring[i].fence);
   523			drm_printf(p, "    rptr: %d\n", state->ring[i].rptr);
   524			drm_printf(p, "    wptr: %d\n", state->ring[i].wptr);
   525			drm_printf(p, "    size: %d\n", MSM_GPU_RINGBUFFER_SZ);
   526	
   527			adreno_show_object(p, state->ring[i].data,
   528				state->ring[i].data_size);
   529		}
   530	
   531		if (state->bos) {
   532			drm_puts(p, "bos:\n");
   533	
   534			for (i = 0; i < state->nr_bos; i++) {
   535				drm_printf(p, "  - iova: 0x%016llx\n",
   536					state->bos[i].iova);
 > 537				drm_printf(p, "    size: %ld\n", state->bos[i].size);
   538	
   539				adreno_show_object(p, state->bos[i].data,
   540					state->bos[i].size);
   541			}
   542		}
   543	
   544		drm_puts(p, "registers:\n");
   545	
   546		for (i = 0; i < state->nr_registers; i++) {
   547			drm_printf(p, "  - { offset: 0x%04x, value: 0x%08x }\n",
   548				state->registers[i * 2] << 2,
   549				state->registers[(i * 2) + 1]);
   550		}
   551	}
   552	#endif
   553	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 43377 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/freedreno/attachments/20180630/1b02ade3/attachment-0001.gz>