[Freedreno] [PATCH 00/12] drm/msm: dpu: Clean up runtime power handling

Sean Paul sean at poorly.run
Mon Nov 12 19:42:04 UTC 2018


From: Sean Paul <seanpaul at chromium.org>

I started pulling a thread last week when looking at dpu locking. It led
me into the power_handle code and eventually runtime suspend/resume.

This set removes the power_handle stuff entirely. I'm sure it's more
useful when there are multiple clients/handles/events, but for our case
with one handle/client/event, it's just overcomplicating things.

Once the power_handle code is out of the way, I added a few patches on
the end that move the runtime resume code out of crtc and into encoder.
The benefit of this is to avoid inspecting crtc->state without holding
the modeset lock.

There's also a few trivial changes sprinkled through the series.

PTAL,

Sean


Sean Paul (12):
  drm/msm: dpu: Remove dpu_power_handle_get_dbus_name()
  drm/msm: dpu: Remove unused trace_dpu_perf_update_bus()
  drm/msm: dpu: Remove dpu_power_client
  drm/msm: dpu: Don't use power_event for vbif_init_memtypes
  drm/msm: dpu: Handle crtc pm_runtime_resume() directly
  drm/msm: dpu: Remove power_handle from core_perf
  drm/msm: dpu: Include dpu_io_util.h directly in dpu_kms.h
  drm/msm: dpu: Move DPU_POWER_HANDLE_DBUS_ID to core_perf
  drm/msm: dpu: Remove dpu_power_handle
  drm/msm: dpu: Fix typo in dpu_encoder
  drm/msm: dpu: Add ->enabled to dpu_encoder_virt
  drm/msm: dpu: Move crtc runtime resume to encoder

 drivers/gpu/drm/msm/Makefile                  |   1 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  37 ++-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h |  22 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c      |  45 +---
 drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.h      |   4 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   |  53 ++--
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.h   |   4 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       |  53 +---
 drivers/gpu/drm/msm/disp/dpu1/dpu_kms.h       |   6 +-
 .../gpu/drm/msm/disp/dpu1/dpu_power_handle.c  | 240 ------------------
 .../gpu/drm/msm/disp/dpu1/dpu_power_handle.h  | 217 ----------------
 drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h     |  29 +--
 12 files changed, 82 insertions(+), 629 deletions(-)
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c
 delete mode 100644 drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h

-- 
Sean Paul, Software Engineer, Google / Chromium OS



More information about the Freedreno mailing list