[Freedreno] [PATCH 07/11] drm/msm: Make irq_postinstall optional

Bruce Wang bzwang at chromium.org
Fri Oct 19 13:56:49 UTC 2018


On Thu, Oct 18, 2018 at 3:58 PM Jordan Crouse <jcrouse at codeaurora.org> wrote:
>
> Allow the KMS operation 'irq_postinstall' to be optional
> so that the target display drivers don't need to define
> a dummy function if they don't need one.
>
> Signed-off-by: Jordan Crouse <jcrouse at codeaurora.org>

Reviewed-by: Bruce Wang <bzwang at chromium.org>

> ---
>  drivers/gpu/drm/msm/msm_drv.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_drv.c b/drivers/gpu/drm/msm/msm_drv.c
> index 107e976be55e..8ce6992dbdff 100644
> --- a/drivers/gpu/drm/msm/msm_drv.c
> +++ b/drivers/gpu/drm/msm/msm_drv.c
> @@ -724,7 +724,11 @@ static int msm_irq_postinstall(struct drm_device *dev)
>         struct msm_drm_private *priv = dev->dev_private;
>         struct msm_kms *kms = priv->kms;
>         BUG_ON(!kms);
> -       return kms->funcs->irq_postinstall(kms);
> +
> +       if (kms->funcs->irq_postinstall)
> +               return kms->funcs->irq_postinstall(kms);
> +
> +       return 0;
>  }
>
>  static void msm_irq_uninstall(struct drm_device *dev)
> --
> 2.18.0
>


More information about the Freedreno mailing list