[Freedreno] [PATCH 10/11] drm/msm/gpu: Add trace events for tracking GPU submissions

[kbuild test robot]

Hi Jordan,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on robclark/msm-next]
[also build test WARNING on next-20181019]
[cannot apply to v4.19-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Jordan-Crouse/drm-msm-GPU-updates-for-4-21/20181019-222154
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   In file included from include/trace/define_trace.h:96:0,
                    from drivers/gpu/drm/msm/msm_gpu_trace.h:90,
                    from drivers/gpu/drm/msm/msm_gpu_tracepoints.c:6:
   include/trace/../../drivers/gpu/drm/msm/msm_gpu_trace.h: In function 'trace_raw_output_msm_gpu_submit_retired':
>> include/trace/../../drivers/gpu/drm/msm/msm_gpu_trace.h:80:16: warning: format '%d' expects argument of type 'int', but argument 7 has type 'u64 {aka long long unsigned int}' [-Wformat=]
         TP_printk("id=%d pid=%d ring=%d:%d elapsed=%d ns mhz=%lld start=%lld end=%lld",
                   ^
   include/trace/trace_events.h:360:22: note: in definition of macro 'DECLARE_EVENT_CLASS'
     trace_seq_printf(s, print);     \
                         ^~~~~
   include/trace/trace_events.h:79:9: note: in expansion of macro 'PARAMS'
            PARAMS(print));         \
            ^~~~~~
>> include/trace/../../drivers/gpu/drm/msm/msm_gpu_trace.h:56:1: note: in expansion of macro 'TRACE_EVENT'
    TRACE_EVENT(msm_gpu_submit_retired,
    ^~~~~~~~~~~
>> include/trace/../../drivers/gpu/drm/msm/msm_gpu_trace.h:80:6: note: in expansion of macro 'TP_printk'
         TP_printk("id=%d pid=%d ring=%d:%d elapsed=%d ns mhz=%lld start=%lld end=%lld",
         ^~~~~~~~~
   In file included from include/trace/trace_events.h:394:0,
                    from include/trace/define_trace.h:96,
                    from drivers/gpu/drm/msm/msm_gpu_trace.h:90,
                    from drivers/gpu/drm/msm/msm_gpu_tracepoints.c:6:
   include/trace/../../drivers/gpu/drm/msm/msm_gpu_trace.h:80:50: note: format string is defined here
         TP_printk("id=%d pid=%d ring=%d:%d elapsed=%d ns mhz=%lld start=%lld end=%lld",
                                                    ~^
                                                    %lld

vim +80 include/trace/../../drivers/gpu/drm/msm/msm_gpu_trace.h

    54	
    55	
  > 56	TRACE_EVENT(msm_gpu_submit_retired,
    57		    TP_PROTO(struct msm_gem_submit *submit, u64 elapsed, u64 clock,
    58			    u64 start, u64 end),
    59		    TP_ARGS(submit, elapsed, clock, start, end),
    60		    TP_STRUCT__entry(
    61			    __field(pid_t, pid)
    62			    __field(u32, id)
    63			    __field(u32, ringid)
    64			    __field(u32, seqno)
    65			    __field(u64, elapsed)
    66			    __field(u64, clock)
    67			    __field(u64, start_ticks)
    68			    __field(u64, end_ticks)
    69			    ),
    70		    TP_fast_assign(
    71			    __entry->pid = pid_nr(submit->pid);
    72			    __entry->id = submit->ident;
    73			    __entry->ringid = submit->ring->id;
    74			    __entry->seqno = submit->seqno;
    75			    __entry->elapsed = elapsed;
    76			    __entry->clock = clock;
    77			    __entry->start_ticks = start;
    78			    __entry->end_ticks = end;
    79			    ),
  > 80		    TP_printk("id=%d pid=%d ring=%d:%d elapsed=%d ns mhz=%lld start=%lld end=%lld",
    81			    __entry->id, __entry->pid, __entry->ringid, __entry->seqno,
    82			    __entry->elapsed, __entry->clock,
    83			    __entry->start_ticks, __entry->end_ticks)
    84	);
    85	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 44453 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/freedreno/attachments/20181020/481c9909/attachment-0001.gz>