[Freedreno] [PATCH v5 02/19] drm/msm/dpu: squash power handle event types

Sean Paul sean at poorly.run
Fri Sep 7 13:07:36 UTC 2018


On Wed, Sep 05, 2018 at 07:08:11PM -0700, Jeykumar Sankaran wrote:
> DPU power handler maintained PRE/POST versions of power
> ENABLE/DISABLE events to accommodate tasks which need be
> handled before/after data bus voting. But since the bus voting
> API's are deprecated and removed from the driver, squash
> the events and their clients respective event handlers
> to handle only ENABLE/DISABLE events.
> 
> changes in v5:
> 	- introduced in the series
> 
> Signed-off-by: Jeykumar Sankaran <jsanka at codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c         | 28 +++++-------------------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c          |  8 +++----
>  drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.c | 15 +++----------
>  drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h | 14 ++++--------
>  4 files changed, 16 insertions(+), 49 deletions(-)
> 

/snip

> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h
> index 344f744..7ed2f42 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_power_handle.h
> @@ -23,17 +23,11 @@
>  
>  #include "dpu_io_util.h"
>  
> -/* event will be triggered before power handler disable */
> -#define DPU_POWER_EVENT_PRE_DISABLE	0x1
> +/* event will be triggered on power handler disable */
> +#define DPU_POWER_EVENT_DISABLE	0x1
>  
> -/* event will be triggered after power handler disable */
> -#define DPU_POWER_EVENT_POST_DISABLE	0x2
> -
> -/* event will be triggered before power handler enable */
> -#define DPU_POWER_EVENT_PRE_ENABLE	0x4
> -
> -/* event will be triggered after power handler enable */
> -#define DPU_POWER_EVENT_POST_ENABLE	0x8
> +/* event will be triggered on power handler enable */
> +#define DPU_POWER_EVENT_ENABLE	0x2

These should be BIT(x), I'll fix it up when I apply.

Reviewed-by: Sean Paul <seanpaul at chromium.org>

Sean

>  
>  /**
>   * mdss_bus_vote_type: register bus vote type
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
> _______________________________________________
> Freedreno mailing list
> Freedreno at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno

-- 
Sean Paul, Software Engineer, Google / Chromium OS


More information about the Freedreno mailing list