[Freedreno] [PATCH 1/3] drm/msm: dpu: Clear frame_busy_mask bit after trace

Abhinav Kumar abhinavk at codeaurora.org
Wed Sep 19 20:01:01 UTC 2018


On 2018-09-19 11:33, Sean Paul wrote:
> From: Sean Paul <seanpaul at chromium.org>
> 
> We're printing the frame_busy_mask in a trace, but after it's been
> cleared. This, as it turns out, is pretty pointless.
> 
> Signed-off-by: Sean Paul <seanpaul at chromium.org>
Reviewed-by: Abhinav Kumar <abhinavk at codeaurora.org>
> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index c2e8985b4c54..e56f29190121 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1361,9 +1361,9 @@ static void dpu_encoder_frame_done_callback(
>  		/* One of the physical encoders has become idle */
>  		for (i = 0; i < dpu_enc->num_phys_encs; i++) {
>  			if (dpu_enc->phys_encs[i] == ready_phys) {
> -				clear_bit(i, dpu_enc->frame_busy_mask);
>  				trace_dpu_enc_frame_done_cb(DRMID(drm_enc), i,
>  						dpu_enc->frame_busy_mask[0]);
> +				clear_bit(i, dpu_enc->frame_busy_mask);
>  			}
>  		}


More information about the Freedreno mailing list