[Freedreno] [PATCH] freedreno: PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT unreachable statement

Rob Clark robdclark at gmail.com
Tue Apr 9 21:32:19 UTC 2019


Good catch, I've pushed this one

Thanks

BR,
-R


On Tue, Apr 9, 2019 at 4:20 AM Khaled Emara <ekhaled1836 at gmail.com> wrote:
>
> There seems to be a duplicate return statement,
> as A2XX doesn't support shader buffers.
> ---
>  src/gallium/drivers/freedreno/freedreno_screen.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/gallium/drivers/freedreno/freedreno_screen.c b/src/gallium/drivers/freedreno/freedreno_screen.c
> index c27b1d36253..40dc16f82cd 100644
> --- a/src/gallium/drivers/freedreno/freedreno_screen.c
> +++ b/src/gallium/drivers/freedreno/freedreno_screen.c
> @@ -290,7 +290,6 @@ fd_screen_get_param(struct pipe_screen *pscreen, enum pipe_cap param)
>         case PIPE_CAP_SHADER_BUFFER_OFFSET_ALIGNMENT:
>                 if (is_a6xx(screen)) return 64;
>                 if (is_a5xx(screen)) return 4;
> -                       return 4;
>                 return 0;
>
>         case PIPE_CAP_MAX_TEXTURE_GATHER_COMPONENTS:
> --
> 2.21.0
>
> _______________________________________________
> Freedreno mailing list
> Freedreno at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/freedreno


More information about the Freedreno mailing list