[Freedreno] [PATCH v4 2/3] drm/msm/dpu: Integrate interconnect API in MDSS

Doug Anderson dianders at chromium.org
Wed Jan 9 16:04:16 UTC 2019


Hi,

On Wed, Jan 9, 2019 at 6:38 AM Georgi Djakov <georgi.djakov at linaro.org> wrote:
>
> Hi Jayant,
>
> On 12/21/18 08:20, Jayant Shekhar wrote:
> > From: Sravanthi Kollukuduru <skolluku at codeaurora.org>
> >
> > The interconnect framework is designed to provide a
> > standard kernel interface to control the settings of
> > the interconnects on a SoC.
> >
> > The interconnect API uses a consumer/provider-based model,
> > where the providers are the interconnect buses and the
> > consumers could be various drivers.
> >
> > MDSS is one of the interconnect consumers which uses the
> > interconnect APIs to get the path between endpoints and
> > set its bandwidth/latency/QoS requirements for the given
>
> Currently we set only bandwidth.
>
> > interconnected path.
> >
> > Changes in v2:
> >       - Remove error log and unnecessary check (Jordan Crouse)
> >
> > Changes in v3:
> >       - Code clean involving variable name change, removal
> >         of extra paranthesis and variables (Matthias Kaehlcke)
> >
> > Changes in v4:
> >       - Add comments, spacings, tabs, proper port name
> >         and icc macro (Georgi Djakov)
>
> The changes should not be part of the commit text, but should move below
> the "---" line.

Drive-by comment that (I believe) they actually should be part of the
commit text.  Convention for changes in the "drm" subsystem appears to
be to include the revision log in the commit text.  This is unlike the
rest of the kernel, but *shrug*.

Try, for instance:

git log --no-merges v4.19..v5.0-rc1 drivers/gpu/drm/msm | grep 'v[0-9]'

-Doug


More information about the Freedreno mailing list