[Freedreno] [PATCH v6 0/5] Add support for DisplayPort driver on

[Stephen Boyd]

Quoting tanmay at codeaurora.org (2020-06-15 16:36:52)
> On 2020-06-15 16:04, Jeffrey Hugo wrote:
> >> >
> >> > I've never seen a block diagram for a driver before...
> >> >
> >> It is here for v5. https://patchwork.freedesktop.org/series/74312/
> > 
> > I think Stephen is nitpicking your wording, and you seem to not be
> > understanding his comment.  I'm sorry if I am mistaken.
> > 
> > The "DP driver" would seem to refer to the linux software driver you
> > are proposing patches for, however this diagram looks like a hardware
> > diagram of the various hardware blocks that the Linux driver code (the
> > "DP driver") is expected to interact with.  I believe you should
> > re-word "The block diagram of DP driver is shown below:" to be more
> > specific of what you are describing with your figure.  IE your words
> > say this is a block diagram of the software, when it looks like it is
> > a block diagram of the hardware.
> 
> Thanks for reviews.
> 
> I am not sure what Stephen meant, but this diagram was available before.
> 
> Just for clarification this is not hardware diagram at all.
> This is modeling of DP driver for msm.
> Each box name above except "DRM framework", is file name in driver i.e. 
> software module.
> Each line and arrow shows how modules interact with each other.
> 
> For example, "DP PARSER" Box is pointing towards "DEVICE TREE" Box, that 
> means
> dp_parser.c file contains functions which are parsing device tree 
> properties and so on...

Yes sorry for being obtuse. To be more direct I'll just say that needing
to have a block diagram for a device driver is not a great start. Device
drivers shouldn't be as complicated to need a block diagram to guide the
reviewer. If we need them then we've failed to consolidate enough logic
into the core device driver frameworks.