[Freedreno] [PATCH] drm/msm/dpu: ensure device suspend happens during PM sleep
Doug Anderson
dianders at chromium.org
Tue Mar 24 14:35:18 UTC 2020
Hi,
On Sun, Mar 22, 2020 at 11:14 PM Kalyan Thota <kalyan_t at codeaurora.org> wrote:
>
> "The PM core always increments the runtime usage counter
> before calling the ->suspend() callback and decrements it
> after calling the ->resume() callback"
>
> DPU and DSI are managed as runtime devices. When
> suspend is triggered, PM core adds a refcount on all the
> devices and calls device suspend, since usage count is
> already incremented, runtime suspend was not getting called
> and it kept the clocks on which resulted in target not
> entering into XO shutdown.
>
> Add changes to manage runtime devices during pm sleep.
>
> Changes in v1:
> - Remove unnecessary checks in the function
> _dpu_kms_disable_dpu (Rob Clark).
I'm wondering what happened with my feedback on v1, AKA:
https://lore.kernel.org/r/CAD=FV=VxzEV40g+ieuEN+7o=34+wM8MHO8o7T5zA1Yosx7SVWg@mail.gmail.com
Maybe you didn't see it? ...or if you or Rob think I'm way off base
(always possible) then please tell me so.
Thanks!
-Doug
More information about the Freedreno
mailing list