[Freedreno] [PATCH 11/18] iommu/fsl_pamu: remove the snoop_id field
Christoph Hellwig
hch at lst.de
Thu Apr 1 09:36:42 UTC 2021
On Tue, Mar 30, 2021 at 01:58:17PM +0100, Will Deacon wrote:
> pamu_config_ppaace() takes quite a few useless parameters at this stage,
> but anyway:
I'll see it it makes sense to throw in another patch at the end to cut
it down a bit more.
> Acked-by: Will Deacon <will at kernel.org>
>
> Do you know if this driver is actually useful? Once the complexity has been
> stripped back, the stubs and default values really stand out.
Yeah. No idea what the usefulness of this driver is. Bascially all it
seems to do is to setup a few registers to allow access to the whole
physical memory. But maybe that is required on this hardware to allow
for any DMA access?
More information about the Freedreno
mailing list