[Freedreno] [PATCH 00/15] replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Claudio Suarez cssk at net-c.es
Fri Oct 15 11:36:58 UTC 2021


Copy&paste from the TODO document Documentation/gpu/todo.rst 

===
Replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi
---------------------------------------------------------------

Once EDID is parsed, the monitor HDMI support information is available through
drm_display_info.is_hdmi. Many drivers still call drm_detect_hdmi_monitor() to
retrieve the same information, which is less efficient.

Audit each individual driver calling drm_detect_hdmi_monitor() and switch to
drm_display_info.is_hdmi if applicable.
=====

I did it in two steps:
- check that drm_display_info has a correct value.
- in that case, replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi

Almost all occurrences of drm_detect_hdmi_monitor() could be changed. Some
small inconsistencies have been solved.

Stats:
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c            | 23 ++++++++++++++++-------
 drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.h            |  2 ++
 drivers/gpu/drm/amd/amdgpu/amdgpu_display.c               |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_encoders.c              |  4 ++--
 drivers/gpu/drm/amd/amdgpu/atombios_encoders.c            |  6 +++---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c         |  3 +--
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_helpers.c | 39 ++++++++++++---------------------------
 drivers/gpu/drm/amd/display/dc/core/dc.c                  |  2 +-
 drivers/gpu/drm/amd/display/dc/dm_helpers.h               |  2 +-
 drivers/gpu/drm/bridge/adv7511/adv7511_drv.c              |  2 +-
 drivers/gpu/drm/bridge/sii902x.c                          |  2 +-
 drivers/gpu/drm/bridge/synopsys/dw-hdmi.c                 |  2 +-
 drivers/gpu/drm/drm_edid.c                                |  2 ++
 drivers/gpu/drm/exynos/exynos_hdmi.c                      |  6 ++++--
 drivers/gpu/drm/gma500/cdv_intel_hdmi.c                   |  3 ++-
 drivers/gpu/drm/gma500/psb_intel_sdvo.c                   |  6 ++++--
 drivers/gpu/drm/i915/display/intel_connector.c            |  5 +++++
 drivers/gpu/drm/i915/display/intel_connector.h            |  1 +
 drivers/gpu/drm/i915/display/intel_hdmi.c                 |  2 +-
 drivers/gpu/drm/i915/display/intel_sdvo.c                 |  3 ++-
 drivers/gpu/drm/msm/hdmi/hdmi_connector.c                 |  2 +-
 drivers/gpu/drm/nouveau/dispnv50/disp.c                   |  4 ++--
 drivers/gpu/drm/nouveau/dispnv50/head.c                   |  8 +-------
 drivers/gpu/drm/nouveau/nouveau_connector.c               |  2 +-
 drivers/gpu/drm/nouveau/nouveau_connector.h               |  6 ++++++
 drivers/gpu/drm/radeon/atombios_encoders.c                |  6 +++---
 drivers/gpu/drm/radeon/radeon_connectors.c                | 20 ++++++++++++++------
 drivers/gpu/drm/radeon/radeon_display.c                   |  2 +-
 drivers/gpu/drm/radeon/radeon_encoders.c                  |  4 ++--
 drivers/gpu/drm/radeon/radeon_mode.h                      |  1 +
 drivers/gpu/drm/rockchip/inno_hdmi.c                      |  4 ++--
 drivers/gpu/drm/rockchip/rk3066_hdmi.c                    |  2 +-
 drivers/gpu/drm/sti/sti_hdmi.c                            | 10 ++++++----
 drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c                    |  4 ++--
 drivers/gpu/drm/tegra/hdmi.c                              |  6 +-----
 drivers/gpu/drm/vc4/vc4_hdmi.c                            |  6 +++---
 drivers/gpu/drm/zte/zx_hdmi.c                             |  4 ++--
 37 files changed, 112 insertions(+), 96 deletions(-)

Best regards.
Claudio Suarez






More information about the Freedreno mailing list