[Freedreno] [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with drm_bridge_connector

[Abhinav Kumar]

On 3/16/2022 9:45 AM, Sankeerth Billakanti (QUIC) wrote:
>> Subject: Re: [RFC PATCH v2 4/5] drm/msm/dp: replace dp_connector with
>> drm_bridge_connector
>> Date: Wed, 23 Feb 2022 16:40:56 -0800
>> From: Kuogee Hsieh <quic_khsieh at quicinc.com>
>> To: Stephen Boyd <swboyd at chromium.org>, Dmitry Baryshkov
>> <dmitry.baryshkov at linaro.org>
>> CC: Abhinav Kumar <quic_abhinavk at quicinc.com>, Bjorn Andersson
>> <bjorn.andersson at linaro.org>, Rob Clark <robdclark at gmail.com>, Sean Paul
>> <sean at poorly.run>, David Airlie <airlied at linux.ie>, Daniel Vetter
>> <daniel at ffwll.ch>, linux-arm-msm at vger.kernel.org, dri-
>> devel at lists.freedesktop.org, freedreno at lists.freedesktop.org
>>
>>
>> On 2/23/2022 1:33 PM, Stephen Boyd wrote:
>>> Quoting Kuogee Hsieh (2022-02-23 10:27:26)
>>>> On 2/23/2022 10:22 AM, Dmitry Baryshkov wrote:
>>>>> On 23/02/2022 20:21, Kuogee Hsieh wrote:
>>>>>
>>>>> In the panel device node.
>>>>>
>>>>> Can you please share it too?
>>>>
>>>> &soc {
>>>>            edp_power_supply: edp_power {
>>>>                    compatible = "regulator-fixed";
>>>>                    regulator-name = "edp_backlight_power";
>>>>
>>>>                    regulator-always-on;
>>>>                    regulator-boot-on;
>>>>            };
>>>>
>>>>            edp_backlight: edp_backlight {
>>>>                    compatible = "pwm-backlight";
>>>>
>>>>                    pwms = <&pm8350c_pwm 3 65535>;
>>>>                    power-supply = <&edp_power_supply>;
>>>>                    enable-gpio = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>;
>>>>
>>>>                    pinctrl-names = "default";
>>>>                    pinctrl-0 = <&backlight_pwm_default>;
>>>>            };
>>>>
>>>>            edp_panel: edp_panel {
>>>>                    compatible = "sharp_lq140m1jw46";
>>> Is that supposed to be sharp,lq140m1jw46 with a comma instead of an
>>> underscore?
>>
>> Stephen,
>>
>> This is our internal branch which does not have patches up to date yet.
>>
>> I will cherry-pick newer edp related patches which are under review now to
>> re test it.
> 
> Tested-by: Sankeerth Billakanti <quic_sbillaka at quicinc.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
> 
> Detect returned eDP not connected because the panel power was not on and mode_valid was failing because the DP mode_valid is different from eDP