[Freedreno] [PATCH v5 1/6] drm/msm/dpu: drop unused lm_max_width from RM
Abhinav Kumar
quic_abhinavk at quicinc.com
Thu Feb 10 00:08:17 UTC 2022
On 1/21/2022 1:06 PM, Dmitry Baryshkov wrote:
> No code uses lm_max_width from resource manager, so drop it. Instead of
> calculating the lm_max_width, code can use max_mixer_width field from
> the hw catalog.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> Reviewed-by: Stephen Boyd <swboyd at chromium.org>
Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c | 12 ------------
> drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h | 4 ----
> 2 files changed, 16 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> index f9c83d6e427a..b5b1ea1e4de6 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.c
> @@ -114,18 +114,6 @@ int dpu_rm_init(struct dpu_rm *rm,
> goto fail;
> }
> rm->mixer_blks[lm->id - LM_0] = &hw->base;
> -
> - if (!rm->lm_max_width) {
> - rm->lm_max_width = lm->sblk->maxwidth;
> - } else if (rm->lm_max_width != lm->sblk->maxwidth) {
> - /*
> - * Don't expect to have hw where lm max widths differ.
> - * If found, take the min.
> - */
> - DPU_ERROR("unsupported: lm maxwidth differs\n");
> - if (rm->lm_max_width > lm->sblk->maxwidth)
> - rm->lm_max_width = lm->sblk->maxwidth;
> - }
> }
>
> for (i = 0; i < cat->merge_3d_count; i++) {
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h
> index 1f12c8d5b8aa..0f27759211b5 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_rm.h
> @@ -20,8 +20,6 @@ struct dpu_global_state;
> * @ctl_blks: array of ctl hardware resources
> * @intf_blks: array of intf hardware resources
> * @dspp_blks: array of dspp hardware resources
> - * @lm_max_width: cached layer mixer maximum width
> - * @rm_lock: resource manager mutex
> */
> struct dpu_rm {
> struct dpu_hw_blk *pingpong_blks[PINGPONG_MAX - PINGPONG_0];
> @@ -30,8 +28,6 @@ struct dpu_rm {
> struct dpu_hw_blk *intf_blks[INTF_MAX - INTF_0];
> struct dpu_hw_blk *dspp_blks[DSPP_MAX - DSPP_0];
> struct dpu_hw_blk *merge_3d_blks[MERGE_3D_MAX - MERGE_3D_0];
> -
> - uint32_t lm_max_width;
> };
>
> /**
More information about the Freedreno
mailing list