[Freedreno] [PATCH v2 3/3] drm/msm: move msm_readl/_writel to msm_drv.h

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Thu Jan 6 00:02:53 UTC 2022


On Thu, 6 Jan 2022 at 02:43, Stephen Boyd <swboyd at chromium.org> wrote:
>
> Quoting Dmitry Baryshkov (2022-01-05 15:27:00)
> > With the reglog removal, msm_readl/_writel became single line wrappers
> > around readl/writel. Move those two wrappers and msm_rmw to msm_drv.h to
> > remove need for extra function calls when doing register writes.
> >
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> > ---
>
> Reviewed-by: Stephen Boyd <swboyd at chromium.org>
>
> Any chance this can go further and replace msm_readl/msm_writel with
> readl/writel directly?

This can go on a step-by-step basis. But practically yes. With this
change in place we should be able to drop most of the io wrappers.

-- 
With best wishes
Dmitry


More information about the Freedreno mailing list