[Freedreno] [PATCH 2/2] drm/msm/dp: remove dp_display_en/disable prototypes and data argument

Dmitry Baryshkov dmitry.baryshkov at linaro.org
Fri Jun 17 20:29:47 UTC 2022


On 17/06/2022 23:15, Stephen Boyd wrote:
> Quoting Dmitry Baryshkov (2022-06-17 12:49:21)
>> Remove unused dp_display_en/disable prototypes. While we are at it,
>> remove extra 'data' argument that is unused.
>>
>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
>> ---
>>   drivers/gpu/drm/msm/dp/dp_display.c | 13 +++++--------
>>   1 file changed, 5 insertions(+), 8 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
>> index 1e34ac2126f6..42ceb4c5796c 100644
>> --- a/drivers/gpu/drm/msm/dp/dp_display.c
>> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
>> @@ -607,9 +607,6 @@ static int dp_hpd_plug_handle(struct dp_display_private *dp, u32 data)
>>          return 0;
>>   };
>>
>> -static int dp_display_enable(struct dp_display_private *dp, u32 data);
>> -static int dp_display_disable(struct dp_display_private *dp, u32 data);
>> -
> 
> This part looks good.
> 
>>   static void dp_display_handle_plugged_change(struct msm_dp *dp_display,
>>                  bool plugged)
>>   {
>> @@ -856,7 +853,7 @@ static int dp_display_set_mode(struct msm_dp *dp_display,
>>          return 0;
>>   }
>>
>> -static int dp_display_enable(struct dp_display_private *dp, u32 data)
>> +static int dp_display_enable(struct dp_display_private *dp)
> 
> This will conflict with Kuogee's patch[1]

Ack, missed that. I'll rebase it on top of Kuogee's patch and send v2.

> 
>>   {
>>          int rc = 0;
>>          struct msm_dp *dp_display = &dp->dp_display;
> 
> [1] https://lore.kernel.org/r/1655411200-7255-1-git-send-email-quic_khsieh@quicinc.com


-- 
With best wishes
Dmitry


More information about the Freedreno mailing list