[Freedreno] [PATCH] drm/msm/dpu: add missing break statement for update_pending_flush_wb()
Dmitry Baryshkov
dmitry.baryshkov at linaro.org
Mon May 2 08:06:04 UTC 2022
On Mon, 2 May 2022 at 08:39, Abhinav Kumar <quic_abhinavk at quicinc.com> wrote:
>
> Add missing break statement for dpu_hw_ctl_update_pending_flush_wb().
> Otherwise this leads to below build warning.
>
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c:273:2:
> warning: unannotated fall-through between switch labels
> default:
> ^
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c:273:2:
> note: insert 'break;' to avoid fall-through
> default:
> ^
> break;
> 1 warning generated.
>
> Fixes: 2e0086d8c61d ("drm/msm/dpu: add changes to support writeback in hw_ctl")
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
> index 254fdf06bb42..c33e7ef611a6 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_ctl.c
> @@ -270,6 +270,7 @@ static void dpu_hw_ctl_update_pending_flush_wb(struct dpu_hw_ctl *ctx,
> case WB_1:
> case WB_2:
> ctx->pending_flush_mask |= BIT(WB_IDX);
> + break;
> default:
> break;
> }
> --
> 2.7.4
>
--
With best wishes
Dmitry
More information about the Freedreno
mailing list