[Freedreno] [PATCH] drm/msm/disp/dpu1: remove supoerflous init

Abhinav Kumar quic_abhinavk at quicinc.com
Tue May 24 17:17:37 UTC 2022



On 5/24/2022 3:35 AM, Vinod Koul wrote:
> Commit 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in
> encoder") added dsc_common_mode variable which was set to zero but then
> again programmed, so drop the supoerflous init.
Both in the subject line and here, typo
supoerflous ---> superfluous

Other than that,
Reviewed-by: Abhinav Kumar <quic_abhinavk at quicinc.com>

> 
> Fixes: 58dca9810749 ("drm/msm/disp/dpu1: Add support for DSC in encoder")
> Reported-by: kernel test robot <yujie.liu at intel.com>
> Signed-off-by: Vinod Koul <vkoul at kernel.org>
> ---
>   drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> index 51f24ba68375..388125c8bda1 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c
> @@ -1798,7 +1798,6 @@ static void dpu_encoder_prep_dsc(struct dpu_encoder_virt *dpu_enc,
>   		}
>   	}
>   
> -	dsc_common_mode = 0;
>   	pic_width = dsc->drm->pic_width;
>   
>   	dsc_common_mode = DSC_MODE_MULTIPLEX | DSC_MODE_SPLIT_PANEL;


More information about the Freedreno mailing list