[Freedreno] [PATCH v3 08/13] drm/msm/dpu: remove QoS teardown on plane destruction
Jessica Zhang
quic_jesszhan at quicinc.com
Fri Dec 1 19:49:14 UTC 2023
On 7/29/2023 6:19 PM, Dmitry Baryshkov wrote:
> There is little point in disabling QoS on plane destruction: it happens
> during DPU device destruction process, after which there will be no
> running planes.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov at linaro.org>
Reviewed-by: Jessica Zhang <quic_jesszhan at quicinc.com>
> ---
> drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> index aba5185e1d66..f114efee1b57 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_plane.c
> @@ -1173,17 +1173,10 @@ static void dpu_plane_atomic_update(struct drm_plane *plane,
> static void dpu_plane_destroy(struct drm_plane *plane)
> {
> struct dpu_plane *pdpu = plane ? to_dpu_plane(plane) : NULL;
> - struct dpu_plane_state *pstate;
>
> DPU_DEBUG_PLANE(pdpu, "\n");
>
> if (pdpu) {
> - pstate = to_dpu_plane_state(plane->state);
> - _dpu_plane_set_qos_ctrl(plane, &pstate->pipe, false);
> -
> - if (pstate->r_pipe.sspp)
> - _dpu_plane_set_qos_ctrl(plane, &pstate->r_pipe, false);
> -
> /* this will destroy the states as well */
> drm_plane_cleanup(plane);
>
> --
> 2.39.2
>
More information about the Freedreno
mailing list